Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix driver responses #10

Merged
merged 4 commits into from
Mar 2, 2015
Merged

Fix driver responses #10

merged 4 commits into from
Mar 2, 2015

Conversation

skyline-gleb
Copy link
Contributor

No description provided.

@@ -59,6 +59,11 @@ public static string ResponseString(HttpStatusCode statusCode, string content)
return responseString.ToString();
}

public static bool IsClientError(HttpStatusCode statusCode)
{
return ((int)statusCode / 100) == 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как-то хаковато, может лучше все таки написать statusCode >= 400 && statusCode < 500?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ок

@skyline-gleb skyline-gleb force-pushed the fix-driver-responses branch from 4f65af3 to 8dfcf5c Compare March 1, 2015 15:36
NickAb added a commit that referenced this pull request Mar 2, 2015
Fixes c# selenium binding not working with driver 👍
@NickAb NickAb merged commit a6f8563 into master Mar 2, 2015
@NickAb NickAb deleted the fix-driver-responses branch March 2, 2015 13:57
NickAb pushed a commit that referenced this pull request Oct 14, 2016
…extension

Allow attributes from FrameworkElementExtensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants